Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts multipage document display with React example. #136

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

jamie-lemon
Copy link
Collaborator

Need to figure out what the problem is here ...

@jamie-lemon jamie-lemon requested a review from ccxvii February 4, 2025 14:37

console.log("load pages");
let pageStack = new Array();
//const totalPages = 1; // this works, but is not what we want :)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccxvii From here if there is just one page I get a render, when I try more than one I get an invalid page index ( note the test PDF only has 3 pages)

@jamie-lemon
Copy link
Collaborator Author

This is updated to work with the latest version on NPM 1.3.0 which ensures the PDFDocument instance is instantiated at the wrapper level.

@jamie-lemon jamie-lemon merged commit 013a842 into master Feb 5, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant