Remove inappropriate generic aliases for D050000L #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "D050000L" font was marked as an alias for "fantasy" but shouldn't be. According to the W3C CSS1 generic font-family definitions: "Fantasy fonts are primarily decorative or expressive fonts that contain decorative or expressive representations of characters. These do not include Pi or Picture fonts which do not represent actual characters."
|
Fixes #27 |
|
Thanks, when can we expect a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the generic "fantasy" font aliases for the D050000L symbol font.
The D050000L font was marked as an alias for "fantasy" but shouldn't be. As a result, if another "fantasy" font isn't installed with a higher priority, D050000L is used by some browsers (in my case Firefox, but not Chromium) when a fantasy font is requested. This results in unreadable text:
According to the W3C CSS1 generic font-family definitions: "Fantasy fonts are primarily decorative or expressive fonts that contain decorative or expressive representations of characters. These do not include Pi or Picture fonts which do not represent actual characters."
After removing the aliases locally and running
fc-cache -rv, the text is readable again (although it just uses the default sans-serif font now since I apparently don't have another fantasy font installed).(Also see my bugrep on the Pop!_OS tracker, someone else's Fedora report and an issue in this repo that provided the solution)