Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telegram API #72

Closed
wants to merge 4 commits into from
Closed

Add Telegram API #72

wants to merge 4 commits into from

Conversation

Real96
Copy link

@Real96 Real96 commented Jan 7, 2025

Implement what was asked in #68

Scripts/1.ahk Outdated
Comment on lines 14 to 16
global telegramToken := "" ; write the telegram bot token value inside the quotes
global telegramChatID := "" ; write the telegram chat id value inside the quotes
global telegramTopicID := "" ; write the telegram topic id value inside the quotes or leave blank

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to set up the variables in the Settings.ini file, to call them after the other globals.
You'll have to do the GUI as for discord id and discord webhook for telegramChatId and telegramTopicId

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to set up the variables in the Settings.ini file, to call them after the other globals. You'll have to do the GUI as for discord id and discord webhook for telegramChatId and telegramTopicId

If you read the issue I linked, @Arturo-1212 doesn't want to add the feature in the GUI

Copy link

@william-wtr92 william-wtr92 Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the GUI but vars are better set in Settings.ini

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the GUI but vars are better set in Settings.ini

But the Settings.ini file doesn't exist when you start the bot for the first time. This way you should start the bot first and then edit the settings. Isn't it?

Copy link

@william-wtr92 william-wtr92 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be tested: if you commit a Settings.ini with these vars and you start the GUI and enter the fields, it will merge the Telegram vars and the ones added by the GUI.
If this solution doesn't work, there's really no other way than to declare them in the code.

Copy link
Author

@Real96 Real96 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it worked, so i made a new commit. The only downside i see is that the Settings.ini file must be removed from the .gitignore file, so when the file is edited it will appear as a new file to be pushed from the local cloned repo of the project

Copy link

@william-wtr92 william-wtr92 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey good ^^. Now we wait the approve of @Arturo-1212.

@Arturo-1212
Copy link
Owner

Like a mentioned in that post this won't be added to the main branch at this time.

@Arturo-1212 Arturo-1212 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants