Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #293 #297

Closed

Conversation

Vedant-Manjrekar
Copy link

Related Issue

Changes you made :

  • Added Link to this Github repository in the footer

Describe the changes :

  • Link to redirect user to this Github repository was added along with a github logo in the "Follow us" section of footer which also redirects user to this repository.

Check list :

  • I have followed code style of this project.
  • I have read the CONTRIBUTING document.
  • All the aspects mentioned in the issue are covered.
  • The website is properly working after my changes.
  • 🌟 ed the repo

Type of change :

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Output Screenshots :

Screenshot 2022-10-19 at 1 21 27 PM

@Arun9739
Copy link
Owner

@Vedant-Manjrekar Good
But plz mention the same in all page's footer.
You have changed it in only on home page.

Also resolve the branch conflicts.

@Arun9739 Arun9739 added enhancement New feature or request hacktoberfest Changes-pending Changes are not satisactory labels Oct 19, 2022
@Arun9739
Copy link
Owner

@Vedant-Manjrekar Plz resolve branch conflicts for merging

@Vedant-Manjrekar
Copy link
Author

Done @Arun9739
Screenshot 2022-10-22 at 7 23 33 PM

@Arun9739
Copy link
Owner

@Vedant-Manjrekar There have been branch conflicts again
Plz resolve

@Vedant-Manjrekar
Copy link
Author

See @Arun9739 there is no point in resolving the conflicts again and again if you are not going to my merged the PR in time. Last time I resolved the conflict was 6 days ago, that's reasonable amount of time to review and merge a PR

@Arun9739
Copy link
Owner

@Vedant-Manjrekar Sorry for the problem caused.
But as you have changed a lot of files, there is branch conflict arising after each merge.
I have not commented bcz I thought you would resolve it.

It would be better if you ca create a new PR, so for the better mergability. Else you can resolve also, no problem.

@Arun9739
Copy link
Owner

@Vedant-Manjrekar Due to inactivity this PR will be closed.

@Arun9739 Arun9739 closed this Oct 31, 2022
@Arun9739 Arun9739 added invalid This doesn't seem right and removed enhancement New feature or request Changes-pending Changes are not satisactory labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants