Saam/ec (#1) #241
Closed
Saam/ec (#1) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement abstract pubk,privk interfaces, implement rsa parity, implement ed25519, implementec_p256k1, add unit tests * add erlang/rust compatibility tests * implement raw serialization, add identifier (owner) derivation from raw pubkey, add unit tests * address feedbacks: more ergonomic type interfaces, avoid input params mutation * fix test * update interfaces to support new keys/backward compatible * add shim for crypto module for older node versions * add recover method * remove ed15519 * add tests for recovery * remove owner from secp256k1 transactions, modify signature data for secp256k1 * finalize rsa tests, use new rsa module all around
|
why another new PR? there's no history in this one :-/ |
|
closed in favor of #240 |
|
thanks Saam 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement abstract pubk,privk interfaces, implement rsa parity, implement ed25519, implementec_p256k1, add unit tests
add erlang/rust compatibility tests
implement raw serialization, add identifier (owner) derivation from raw pubkey, add unit tests
address feedbacks: more ergonomic type interfaces, avoid input params mutation
fix test
update interfaces to support new keys/backward compatible
add shim for crypto module for older node versions
add recover method
remove ed15519
add tests for recovery
remove owner from secp256k1 transactions, modify signature data for secp256k1
finalize rsa tests, use new rsa module all around