Feature/verify tool sample #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {seek_offset, SeekOffset}, | ||
| {reply, io_lib:format("~p", [Reply])}, | ||
| {is_recorded_unpacked, io_lib:format("~p", [UnpackedReply])}]), | ||
| case RequestOrigin of |
There was a problem hiding this comment.
log_chunk_error should already skip logging for http and tx_data origins - is there an origin that I missed? I can add it to the matching clause
| %% such that if an offset is sampled, no other offsets are selected from the | ||
| %% open interval (Offset - ?DATA_CHUNK_SIZE, Offset + ?DATA_CHUNK_SIZE). | ||
| generate_sample_offsets(Start, End, Count) when is_integer(Start), is_integer(End) -> | ||
| Candidates = lists:seq(Start + 1, End, ?DATA_CHUNK_SIZE), |
There was a problem hiding this comment.
For a full 3.6TB partition I think Candidates will be a list of length 14.4 million entries or have I misread?
Could that become a memory issue (e.g. if running verify on multiple storage modules concurrently)?
| %% Use generate_sample_offsets/3 to obtain offsets (with exclusion) | ||
| %% and then queries ar_data_sync:get_chunk/2 with options to trigger unpacking. | ||
| sample_random_chunks(Count, Packing, Start, End, StoreID) -> | ||
| Offsets = generate_sample_offsets(Start, End, Count), |
There was a problem hiding this comment.
Rather than precalculate the list of offsets, what about doing one offset at a time sampled randomly from the range, and if that chunk exists on disk just adding that offset to a set so we never try it again? Maybe this will avoid the 14.4M offset list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.