dcp: Fix firmware mapping check on t8103/t600x #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janne Grunau <[email protected]>
t8103 and t600x use "asc-dram-mask" in iop-dcp-nub to mask bits out of DMA addresses. This needs to be used in the firmware mappings check/remap since the segments have maskable bits sets. Fixes: 8332e24 ("dcp: Undo carnage from bad stage1 DART code") Signed-off-by: Janne Grunau <[email protected]>
jvoisin
reviewed
May 17, 2024
| memcpy(&tmp, prop, sizeof(tmp)); | ||
| dart->vm_base = tmp; | ||
| } else { | ||
| printf("dart: unexpected length of vm-base property: %u\n", len); |
There was a problem hiding this comment.
shouldn't dart->vm_base be set to 0 here, just in case™?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On t8103/t600x devices the firmware mapping check needs to mask out
asc-drm-mask. Fixes HDMI output initialization in stage 1 on M1* desktop devices.