Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples & guides #119

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Conversation

PyroTech03
Copy link
Contributor

Start of example and guides for events. First half of Agoraphobic's tutorial put down. Moved sidebar "Event" section around to pair the editor sections together, the Chat/Event commands together.

Beginning of the examples section.
Fixed link for Event system tutorial.
reordered to put the editor sections together, chat/event commands together.
First half of Agoraphobic's tutorial.
Uploading Agoraphobic's raw PDF file
Finished Docs Edit and posted link for PDF version, as well as uploaded copy to github docs.
@PyroTech03 PyroTech03 marked this pull request as ready for review October 19, 2023 05:27
@lodicolo
Copy link
Member

image

For some reason the auto-build is deciding to hold you accountable for a change not in this PR. Can you reduce the number of commas in They are what you use to give players their quests, browse shops, environmental puzzles, chests, doors, cutscenes, and just about anything you would want to do outside of combat. in events/introduction.md please? Just can just remove some of the items in the list to shorten it to 5 items (so 4 commas)

I don't want to merge this and then have the deploy fail because of too many commas.

@jcsnider
Copy link
Contributor

image

For some reason the auto-build is deciding to hold you accountable for a change not in this PR. Can you reduce the number of commas in They are what you use to give players their quests, browse shops, environmental puzzles, chests, doors, cutscenes, and just about anything you would want to do outside of combat. in events/introduction.md please? Just can just remove some of the items in the list to shorten it to 5 items (so 4 commas)

I don't want to merge this and then have the deploy fail because of too many commas.

Taking care of this in #132

Copy link
Contributor Author

@PyroTech03 PyroTech03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the descriptions. They were essentially pulling from the way I guess ShareX saved the files to begin with as it had to do with where the screenshot was pulling from.

@lodicolo lodicolo merged commit af9d346 into AscensionGameDev:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants