chore: refactor register window (#2353)

Intersect (Core)/Security/PasswordUtils.cs

@@ -0,0 +1,12 @@
+using System.Security.Cryptography;
+using System.Text;
+
+namespace Intersect.Security;
+
+public partial class PasswordUtils
+{
+    public static string ComputePasswordHash(string password)
+    {
+        return BitConverter.ToString(SHA256.HashData(Encoding.UTF8.GetBytes(password ?? string.Empty))).Replace("-", string.Empty);
+    }
+}

Intersect.Client/Interface/Menu/LoginWindow.cs

@@ -1,5 +1,3 @@
-using System.Security.Cryptography;
-using System.Text;
 using Intersect.Client.Core;
 using Intersect.Client.Framework.File_Management;
 using Intersect.Client.Framework.Gwen.Control;
@@ -9,6 +7,7 @@
 using Intersect.Client.Interface.Game.Chat;
 using Intersect.Client.Localization;
 using Intersect.Client.Networking;
+using Intersect.Security;
 using Intersect.Utilities;
 
 namespace Intersect.Client.Interface.Menu;
@@ -177,7 +176,7 @@ private void TryLogin()
         var password = _savedPass;
         if (!_useSavedPass)
         {
-            password = ComputePasswordHash(_txtPassword.Text.Trim());
+            password = PasswordUtils.ComputePasswordHash(_txtPassword.Text.Trim());
         }
 
         Globals.WaitingOnServer = true;
@@ -209,17 +208,14 @@ private void LoadCredentials()
         _chkSavePass.IsChecked = true;
     }
 
-    private static string ComputePasswordHash(string password) =>
-        BitConverter.ToString(SHA256.HashData(Encoding.UTF8.GetBytes(password ?? string.Empty))).Replace("-", string.Empty);
-
     private void SaveCredentials()
     {
         string username = string.Empty, password = string.Empty;
 
         if (_chkSavePass.IsChecked)
         {
             username = _txtUsername.Text.Trim();
-            password = _useSavedPass ? _savedPass : ComputePasswordHash(_txtPassword.Text.Trim());
+            password = _useSavedPass ? _savedPass : PasswordUtils.ComputePasswordHash(_txtPassword.Text.Trim());
         }
 
         Globals.Database.SavePreference("Username", username);

Intersect.Client/Interface/Menu/MainMenu.cs

@@ -39,7 +39,7 @@ public static void HandleReceivedConfiguration()
 
     private readonly SettingsWindow mSettingsWindow;
 
-    private readonly RegisterWindow mRegisterWindow;
+    private readonly RegistrationWindow mRegisterWindow;
 
     private readonly ResetPasswordWindow mResetPasswordWindow;
 
@@ -73,7 +73,7 @@ public MainMenu(Canvas menuCanvas) : base(menuCanvas)
         mLoginWindow = new LoginWindow(menuCanvas, this);
 
         //Register Controls
-        mRegisterWindow = new RegisterWindow(menuCanvas, this);
+        mRegisterWindow = new RegistrationWindow(menuCanvas, this);
 
         //Forgot Password Controls
         mForgotPasswordWindow = new ForgotPasswordWindow(menuCanvas, this);
@@ -228,7 +228,7 @@ internal void SwitchToWindow<TMainMenuWindow>() where TMainMenuWindow : IMainMen
         {
             mLoginWindow.Show();
         }
-        else if (typeof(TMainMenuWindow) == typeof(RegisterWindow))
+        else if (typeof(TMainMenuWindow) == typeof(RegistrationWindow))
         {
             mRegisterWindow.Show();
         }

Intersect.Client/Interface/Menu/MainMenuWindow.cs

@@ -134,7 +134,7 @@ private void ButtonRegisterOnClicked(Base sender, ClickedEventArgs arguments)
     {
         if (Networking.Network.InterruptDisconnectsIfConnected())
         {
-            _mainMenu.SwitchToWindow<RegisterWindow>();
+            _mainMenu.SwitchToWindow<RegistrationWindow>();
         }
         else
         {
@@ -163,7 +163,7 @@ private void RemoveRegisterEvents()
     private void RegisterConnected(object? sender, EventArgs eventArgs)
     {
         RemoveRegisterEvents();
-        _mainMenu.SwitchToWindow<RegisterWindow>();
+        _mainMenu.SwitchToWindow<RegistrationWindow>();
     }
 
     #endregion Register