enhancement: configurable map items size #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
396cd0d to
a339243
Compare
lodicolo
requested changes
Apr 21, 2023
Comment on lines
41
to
50
| /// <summary> | ||
| /// The width of map items. | ||
| /// </summary> | ||
| public int MapItemHeight { get; set; } = 32; | ||
|
|
||
| /// <summary> | ||
| /// The height of map items. | ||
| /// </summary> | ||
| public int MapItemWidth { get; set; } = 32; | ||
|
|
There was a problem hiding this comment.
The of the map items in pixels.
Also, remove the = 32;, and change these to uints.
If the value is default, you can skip the computation for that dimension and just use the Tile<Dimension>.
Intersect.Client/Maps/MapInstance.cs
Outdated
Comment on lines
736
to
745
| var tileX = key % Options.MapWidth; | ||
| var tileY = (int)Math.Floor(key / (float)Options.MapWidth); | ||
| var x = X + tileX * Options.TileWidth; | ||
| var y = Y + tileY * Options.TileHeight; | ||
| var centerX = x + (Options.TileWidth / 2); | ||
| var centerY = y + (Options.TileHeight / 2); | ||
| var textureWidth = Options.MapItemWidth; | ||
| var textureHeight = Options.MapItemHeight; | ||
| var textureXPosition = centerX - (textureWidth / 2); | ||
| var textureYPosition = centerY - (textureHeight / 2); |
There was a problem hiding this comment.
Most of this computation should only ever happen once: when the configuration is loaded.
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
d3828d0 to
a5e003a
Compare
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
a5e003a to
764662b
Compare
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
764662b to
cd8831a
Compare
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
2 times, most recently
from
f894fb3 to
ebf6bf8
Compare
lodicolo
requested changes
Aug 27, 2023
Intersect.Client/Maps/MapInstance.cs
Outdated
Comment on lines
726
to
727
| var mapItemWidth = preferredMapItemWidth <= 0 ? tileWidth : preferredMapItemWidth; | ||
| var mapItemHeight = preferredMapItemHeight <= 0 ? tileHeight : preferredMapItemHeight; |
There was a problem hiding this comment.
This should be getting done in MapOptions.Validate() in the other file, like I said this gets done when it is loaded.
Also switch to < 1
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
2 times, most recently
from
11faa44 to
6edc76b
Compare
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
2 times, most recently
from
6edc76b to
2808ece
Compare
|
/helptest |
|
Developers have requested community assistance to test the code changes in this pull request. If you'd like to help you can download binaries for this PR here. These builds are only meant for testing to validate bug fixes and could cause significant damage to your game data. In other words, make a backup of your game data before proceeding. Please comment below to provide testing feedback. Thanks! |
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
2808ece to
9a13c2b
Compare
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
9a13c2b to
b6f7f34
Compare
enhances spawned/dropped items in maps by: - Adding configurable size for their sprites. - Centering their sprites in relation to the tiles they occupy.
- removes previously added config/options.cs statics - turns MapItemHeight and MapItemWidth into uints - if configured value is not set or equals <= 0 (default value when uint is not set: 0), the draw method skips the computation and uses the tiles dimensions. - moved out of the loop computation variables that should only happen once at the beginning of the method.
Arufonsu
force-pushed
the
dev/enhancement-configurable-mapitemsize
branch
from
b6f7f34 to
e2fd072
Compare
|
Updated PR for B8 |
lodicolo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhances spawned/dropped items in maps by:
This doesn't requires additional texture loading, this simply allows the users to configure the size the icon textures.
The implementation also makes sure to always center the item's texture in relation with the tile they occupy while considering the configured item render size, this way we are not limited by the boundaries of the tile size of the grid anymore.
Preview: