enhancement: bank withdraw behavior #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arufonsu
force-pushed
the
enhancement/bank-withdraw-slider
branch
2 times, most recently
from
295dd3d to
b13e32a
Compare
lodicolo
requested changes
Sep 19, 2023
Arufonsu
force-pushed
the
enhancement/bank-withdraw-slider
branch
from
9bd65fc to
b4ce650
Compare
Arufonsu
force-pushed
the
enhancement/bank-withdraw-slider
branch
from
b4ce650 to
fffc008
Compare
- Implements the 'FindAvailableInventorySpaceForItem' method to ensure sliders display the correct values for available inventory space. - Instead of blindly opening the item withdraw slider with a max quantity of 0 when there's no space left in the inventory (pointless), we now inform the player: "There is no space left in your inventory for that item!"
itemID default (Guid) is Guid.Empty inventorySlot default (int) is null
Arufonsu
force-pushed
the
enhancement/bank-withdraw-slider
branch
from
fffc008 to
9a13333
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
2023-09-14.21-14-50.mp4
After:
2023-09-14.22-00-38.mp4