fix: properly handle NPCs directions near map borders #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Chore: Renamed the method "DirToEnemy" to "DirectionToTarget" - Adjusted the DirectionToTarget method to properly handle directions near map borders and across different maps.
- Re-adjusts and caches origin and target (MapController.Get) for better map border calculation.
Adjusted the IsFacingTarget method to properly handle direction checks near map borders and across different maps.
lodicolo
requested changes
Oct 13, 2023
Intersect.Server/Entities/Entity.cs
Outdated
Comment on lines
2738
to
2739
| var originMapController = MapController.Get(MapId); | ||
| var targetMapController = MapController.Get(en.MapId); |
There was a problem hiding this comment.
Can you use TryGet and if it fails just return Dir?
Intersect.Server/Entities/Entity.cs
Outdated
Comment on lines
2780
to
2781
| var originMapController = MapController.Get(MapId); | ||
| var targetMapController = MapController.Get(mapId); |
There was a problem hiding this comment.
Same thing with TryGet and returning the default value if either of them fail
lodicolo
requested changes
Oct 13, 2023
Intersect.Server/Entities/Entity.cs
Outdated
Comment on lines
2648
to
2649
| var originMapController = MapController.Get(MapId); | ||
| var targetMapController = MapController.Get(target.MapId); |
There was a problem hiding this comment.
Almost missed this -- also use TryGet and return early if either fail
lodicolo
approved these changes
Oct 13, 2023
1 task
Cheshire92
pushed a commit
to Cheshire92/Intersect-Engine
that referenced
this pull request
Oct 15, 2023
…ev#1940) * fix: DirToEnemy - Chore: Renamed the method "DirToEnemy" to "DirectionToTarget" - Adjusted the DirectionToTarget method to properly handle directions near map borders and across different maps. * chore: IsOneBlockAway - Re-adjusts and caches origin and target (MapController.Get) for better map border calculation. * fix: IsFacingTarget Adjusted the IsFacingTarget method to properly handle direction checks near map borders and across different maps. * enhancement: Adds TryGet for MapController * chore: uses TryGet within IsOneBlockAway * chore: uses TryGet within DirectionToTarget * chore: uses TryGet within IsFacingTarget
Arufonsu
added
bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
2023-10-13.00-36-09.mp4