fix: correct keys on slot packets #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1953 by correcting the
[Key(#)]attributes on the different slot packetsFor some reason the base slot packet had
[Key(3)]on aboolproperty with only an expression-body getter (so quite literally cannot be set even with reflection hacks), and the deposit bank slot was[Key(0)].It appears that there isn't actually a
[Key(0)]on anything? Which is weird, but whatever. The problem is that the weird key situation was causing deserialization to totally break, and I am guessing since our .NET 7 upgrade MessagePack actually expects the code to be correct instead of correcting for developer mistakes.