fix: editor NSE for instance type strings #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodicolo
previously requested changes
May 27, 2024
WeylonSantana
approved these changes
Jul 22, 2024
Arufonsu
dismissed
lodicolo’s stale review
PR already reviewed by @WeylonSantana, Also, @lodicolo's review was resolved.
dhmello
added a commit
to dhmello/Intersect-Engine
that referenced
this pull request
Jul 23, 2024
fix: editor NSE for instance type strings (AscensionGameDev#2260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2259
Instance type strings is not used at all plus, it's triggering an NSE when starting the game editor.
They were hardcoded to use their enum strings instead of their localized strings.
Preview Note: edited the overworld type string in order to show up that the values aren't hard-coded anymore.