[1.20] Update texture encoding #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-dencep
requested changes
Dec 22, 2023
In dev, mandatory = true can be removed for testing the vanilla pipeline
|
Minimum version has been set to 0.2.14. |
|
Oculus can work without embeddium, and I don't want it to be dependent on it (there have been cases where people only needed oculus without embeddium) |
|
It will perform incredibly poorly due to the massive vertex size... but sure. |
dima-dencep
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of Embeddium will make a backwards-incompatible change to how textures are encoded to address visual alignment issues (this change will also be made in Sodium whenever the next release occurs). It will require an Oculus update for shaders to function correctly again.
The reverse is also true: older versions of Embeddium will not work with an Oculus version including this change. However I don't think that's an issue.