Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: language code #49

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: language code #49

wants to merge 4 commits into from

Conversation

wildmer
Copy link
Contributor

@wildmer wildmer commented Dec 12, 2024

This commit aims to solve this problem #48

Apparently the language code is being received in {language_code}_{country_code}:{language_code}
image

Summary by Sourcery

Fix the language code parsing issue and add support for Spanish translations.

New Features:

  • Add a new language file for Spanish (es.json) to support Spanish translations.

Bug Fixes:

  • Fix the language code parsing to correctly handle and extract the language code when it is received in the format {language_code}_{country_code}:{language_code}.

@wildmer wildmer requested a review from AsmSafone as a code owner December 12, 2024 08:15
Copy link

sourcery-ai bot commented Dec 12, 2024

Reviewer's Guide by Sourcery

The PR fixes an issue with language code handling by adding logic to extract the correct language code from a compound format '{language_code}_{country_code}:{language_code}'. It also introduces a new Spanish language file.

ER diagram for language files

erDiagram
    LANG {
        string language_code
    }
    LANG ||--o{ LANGUAGE_FILE : contains
    LANGUAGE_FILE {
        string file_name
    }
    note for LANGUAGE_FILE "New Spanish language file added"
Loading

File-Level Changes

Change Details Files
Added language code parsing logic to handle compound format
  • Added condition to check if language code contains ':' delimiter
  • Split the language string and extract the second part after ':' as the actual language code
lang/__init__.py
Added Spanish language support
  • Created new Spanish language JSON file
lang/es.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wildmer - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Use os.path.join() and validate file path to prevent path traversal vulnerabilities (link)

Overall Comments:

  • The file path construction could be vulnerable to path traversal attacks. Consider adding validation of the language code or using a secure path joining method.
  • The new es.json file appears to be empty. Please ensure it contains the necessary translations.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

lang/__init__.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants