Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Google Sheets API calls to v4 #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the Google Sheets API calls to v4 #223

wants to merge 1 commit into from

Commits on Aug 22, 2021

  1. Update the Google Sheets API calls to v4 

    This PR updates the API calls to Google Sheets to use v4 instead of v3
which was shut down August 2.

Fixes Asmor#217, Fixes Asmor#218, and Fixes Asmor#222 with some caveats, see below.

Full disclosure: I have no idea what I'm doing really with JS, so there
are likely to be improvements to be made.

Potentially Outstanding Issues:
* Uses my personal API Key. Its restricted to Google Sheets API only,
  but I would prefer it be someone else's. Not really a problem right now.
* Each Sheet is loaded in full through a GET request, returned entierly
  as JSON. This results in the load being a bit slow (and a fair amount
  of data comes down, the Official is 33MB of plain text returned for
  example. The load only happens once per sheet.
* I left in all the old code where I could in case improvements can be
  made.
* I do not know JS, so any improvements, especially in the Promises
  area are likely very welcome.

Removed some debug lines I left in sending to console.
    @Lnaden
    Lnaden committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    8886bda View commit details
    Browse the repository at this point in the history