Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIS-158: Move copied Button group from bottom of checkoutlist to top #2214

Merged

Conversation

lathomas64
Copy link
Contributor

@lathomas64 lathomas64 commented Jan 23, 2025

to test:

  • masquerade as a user with checked out items
  • navigate to /MyAccount/CheckedOut
  • you should see the button panel with Renew selected items, renew all, and export to csv at the top of the list if there are 5 or more items in the list.

@@ -70,6 +70,10 @@

//alexander

//imani
### Other Updates
- Added renew all, renew checked, and export to csv buttons to the top of the checkout list. (*IT*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lathomas64 this needs the ticket number added to the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdnoble73 added

@lathomas64 lathomas64 requested a review from mdnoble73 January 28, 2025 22:49
@@ -23,6 +23,16 @@
</div>
{/if}

<div class="btn-group">
{if $renewableCheckouts >= 1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lathomas64 let's do this with 5 or more per Matt's comment on the ticket. Checking with Matt about moving the Export To Excel as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't do Export to Excel per the ticket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted to 5 or more

<a href="#" onclick="AspenDiscovery.Account.renewSelectedTitles()" class="btn btn-sm btn-default">{translate text="Renew Selected Items" isPublicFacing=true}</a>
<a href="#" onclick="AspenDiscovery.Account.renewAll()" class="btn btn-sm btn-default">{translate text="Renew All" isPublicFacing=true}</a>
{/if}
<a class="btn btn-sm btn-default" id="exportToExcel" onclick="return AspenDiscovery.Account.exportCheckouts('{$source}', $('#accountSort_{$source} option:selected').val());">{translate text="Export to CSV" isPublicFacing=true}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lathomas64 can you update to not move the Export To CSV button per the Jira issue? That isn't needed both at the top and bottom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the export button from the upper level of buttons

@mdnoble73 mdnoble73 merged commit 8df20d3 into Aspen-Discovery:25.02.00 Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants