DIS-219: Filter Hold Requests #2216
Conversation
Add the ability to filter holds by excluding those of selected linked users and by displaying only selected holds in the UI.
Update exportHolds so that the new filters are taken into account when holds are exported.
Prevent disply selected filter from filtering out linked users if they are highlighted in the ui
When records are selected and display selected is applied, records were being returned if they had the same record id as a selected record e.g. they had a different user, but were not selected themseleves, this patch adds a check for the userid to prevent this
| @@ -125,6 +125,9 @@ | |||
| - Eliminate the time portion of display dates from Aspen Open Archives search results (DIS-242) (*JStaub*) | |||
|
|
|||
| //alexander | |||
| ### Holds Updates | |||
There was a problem hiding this comment.
@AlexanderBlanchardAC this needs the ticket number in parenthesis before your initials for each change.
There was a problem hiding this comment.
Sorry Mark, missed that. Updated the release notes.
chore: Update change log
AlexanderBlanchardAC
changed the title
There was a problem hiding this comment.
Hi Alexander,
This development does not follow the design patterns that are already established within Aspen with regards to Linked Accounts. In other locations we have the ability to select the active Linked User or all are shown. This type of filter should follow that pattern.
The input to seelect which user to select should be above the tabs (Libby, Boundless, Physical, etc). so that it applies to all tabs without the user having to reselect as they move between tabs and so they don't need to set it for available vs. pending separately.
This functionality should also be included in checked out titles for consistency.
Let me know if you have questions or want to discuss more.
- Mark
Hi Mark, |
|
Look for cases that use the switch-linked-user-form.tpl template. It looks like we deprecated most of those cases, but that allows the user to change back and forth between which account is active. By default you would want to show all accounts so you would likely need to extend the template to optionally include all accounts. |
Cheers Mark, |
|
Do you have more information on the request, there isn't a lot of info in the Jira ticket. Is the use case that I want to see my holds as well as the holds of my child, but not the holds for my partner? If that is the case, having filters at the top where patrons could choose the accounts they want to see (rather than select the ones to hide) would be better. Similar to what we do for materials requests. Then they would default to seeing all accounts in this case. |
Hi Mark, |
Reverse the logic of the filter so that is filters to include records rather than exclude them. Add the current user to the filters so that the user can view just their own records.
Fix issue found in testing, move linked user filter to display whether or not there are holds found and ensure display selected effectd only the unavailable holds section
DIS-219: Reverse Filter
|
Hi Mark, I have moved the filter to the top of the page and reversed the logic so that it filters in rather than filtering out. By default the page shows the holds of the main user and all linked users. I have been asked to open a separate ticket for adding this functionality to checked out titles. |
https://aspen-discovery.atlassian.net/jira/software/c/projects/DIS/boards/2?search=219&selectedIssue=DIS-219