-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql): disable sqls formatter and add sqlfluff #1336
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Seems to be working. One thing is that the default conform timeout in community pack is 500ms, which might not be enough for sqlfluf 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, can you update the README
Closes #1323
📑 Description
This should disable the sqls lsp formatter and use sqlfluff instead. Might as well use sqlfluff diagnostics also, I see them beneficial.
This is the issue with sqls at the moment: sqls-server/sqls#149
ℹ Additional Information
This needs thorough testing, since I'm not sure if all works as expected and I lack knowledge to verify on my own due to being new to neovim ecosystem. Especially different combinations of null-ls/conform/nvim-lint/lspconfig community packs.
I disabled cwd in conform due to default settings requiring a config file to be present for the formatter to work. I didn't notice this behavior in null-ls.
There might be an issue with timeouts for formatting, since I've noticed in other github repos people put 1s or even 5s timeout when using sqlfluff.