-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resized large images for the thumbnails when needed #62
Conversation
…ge images to their name appended with .large
Tested on my Oneplus 2 5.5" 1920*1080 display, and although layout is broken on small displays, stills render correctly. |
Paging @aubincleme for input (especially for this : should we be keeping the larger-size images ?) |
854x480 should be a good resolution |
I think that larger-size images should be kept somewhere else, without weighing this repository. |
cdn.atilla.org ? |
This will let us to serve multiple size |
Nope, it’s also another repository, it’s the same problem ; I think that we should keep the original images in where we actually store them (drive.google.com), and diffuse them only if needed. |
I do not agree on this. This website will certainly need a some point higher DPI version of those images if the website is shown on a high DPI screen |
Ok, let’s make some calculations here :
With all this, we can calculate an approximation of the minimal resolution of a thumbnail in this configuration :
There you have it, in order to be correctly displayed on a 4K screen, a thumbnail should have a resolution greater than 340*216 So, |
I'm not telling do this now. Certainly not. Re-read what I've written. I just meant to say the cdn will be the way to go. It is supposed to, in any matter. I've proposed the High-DPI version here #60. Period. |
So, we actually need to come to a decision : I guess the image resolution is good, but what will we do with the higher-res images ? Do we have a backup of them somewhere else ? Could we use our OwnCloud to store them ? |
We already have backups of those images oh the Google drive of the comm team. We can delete those safely |
Alright, I'll delete the Hi-res files and merge after lunch. |
I can do this right now, it won't take long |
This PR is not to be merged right now, I'm waiting for more feedback on how the different thumbnails look on different sized screens (if somebody has a 2k-plus monitor, he's welcome to give some feedback)
I've resized the thumbnails to 854x480 using
convert $file -resize 854x480 $newfile
, which should give good enough results. Other solutions could be tried.Cheers !
Resolves #59