Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resized large images for the thumbnails when needed #62

Merged
merged 2 commits into from
Aug 22, 2016

Conversation

Alterrien
Copy link
Collaborator

@Alterrien Alterrien commented Aug 10, 2016

This PR is not to be merged right now, I'm waiting for more feedback on how the different thumbnails look on different sized screens (if somebody has a 2k-plus monitor, he's welcome to give some feedback)
I've resized the thumbnails to 854x480 using convert $file -resize 854x480 $newfile, which should give good enough results. Other solutions could be tried.

Cheers !

Resolves #59

…ge images to their name appended with .large
@Wonskcalb
Copy link
Member

Tested on my Oneplus 2 5.5" 1920*1080 display, and although layout is broken on small displays, stills render correctly.

@Alterrien
Copy link
Collaborator Author

Paging @aubincleme for input (especially for this : should we be keeping the larger-size images ?)

@aubincleme
Copy link
Member

854x480 should be a good resolution

@aubincleme
Copy link
Member

I think that larger-size images should be kept somewhere else, without weighing this repository.

@Wonskcalb
Copy link
Member

cdn.atilla.org ?

@Wonskcalb
Copy link
Member

This will let us to serve multiple size

@aubincleme
Copy link
Member

Nope, it’s also another repository, it’s the same problem ; I think that we should keep the original images in where we actually store them (drive.google.com), and diffuse them only if needed.

@Wonskcalb
Copy link
Member

I do not agree on this. This website will certainly need a some point higher DPI version of those images if the website is shown on a high DPI screen

@aubincleme
Copy link
Member

Ok, let’s make some calculations here :

  • Let’s consider that the industry standard in terms of screen resolution is 4K (even if it’s not the case at all)
  • We can display about 10 conference / talk / author «rows» on a 4K screen
  • In each row, the thumbnail takes about 1/12 of the page width
  • The native 4K resolution is 4 096 × 2 160

With all this, we can calculate an approximation of the minimal resolution of a thumbnail in this configuration :

4096 * (1/12) ~= 340
2160 * (1/10) = 216

There you have it, in order to be correctly displayed on a 4K screen, a thumbnail should have a resolution greater than 340*216

So,
Will the website need high-DPI thumbnails at some point ? Maybe
Should we prepare for this ? Certainly not ; we will be able to add high-DPI images in the future anyway.

@Wonskcalb
Copy link
Member

I'm not telling do this now. Certainly not. Re-read what I've written. I just meant to say the cdn will be the way to go. It is supposed to, in any matter. I've proposed the High-DPI version here #60. Period.

@Alterrien
Copy link
Collaborator Author

So, we actually need to come to a decision : I guess the image resolution is good, but what will we do with the higher-res images ? Do we have a backup of them somewhere else ? Could we use our OwnCloud to store them ?

@Wonskcalb
Copy link
Member

We already have backups of those images oh the Google drive of the comm team. We can delete those safely

@Alterrien
Copy link
Collaborator Author

Alright, I'll delete the Hi-res files and merge after lunch.

@Wonskcalb
Copy link
Member

I can do this right now, it won't take long

@Wonskcalb Wonskcalb merged commit 4a530a7 into master Aug 22, 2016
@Wonskcalb Wonskcalb deleted the fix/thumbnail_dpi branch August 22, 2016 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants