Fixes target comparison #2982

AtlasOfLivingAustralia · Sep 11, 2023 · 719377d · 719377d
1 parent 254d9d2
commit 719377d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/grails-app/controllers/au/org/ala/merit/ProjectController.groovy b/grails-app/controllers/au/org/ala/merit/ProjectController.groovy
@@ -1013,12 +1013,15 @@ class ProjectController {
     }
 
     private boolean hasTarget(value) {
-        value != 0 && value != "0"
+        if (value instanceof String) {
+            return value != "0"
+        }
+        value != 0
     }
 
     private boolean hasFinancialYearTarget(Map targetRow) {
         def financialYearTarget = targetRow.financialYearTarget
-        financialYearTarget != 0 && financialYearTarget != "0"
+        hasTarget(financialYearTarget)
     }
 
     @PreAuthorise(accessLevel ='siteAdmin')