Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue2880 #3352

Merged
merged 79 commits into from
Oct 29, 2024
Merged

Feature/issue2880 #3352

merged 79 commits into from
Oct 29, 2024

Conversation

chrisala
Copy link
Collaborator

No description provided.

Copy link
Contributor

@temi temi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a big change. LGTM except for a minor comment.

}

// Maintains the state of which organisation is being edited or added
var selectedOrganisation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot see this variable being used. is it supposed to be self.selectedOrganisation?

@@ -1,232 +0,0 @@
<g:if test="${organisation.projects}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not showing projects associated with an organisation anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gsp fragement was replaced when the NHT related changes were deployed last year (with /shared/projectListByProgram) to match the management unit page behaviour - I just deleted this now as a tidy up.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @temi yes, I've fix this.

@temi
Copy link
Contributor

temi commented Oct 28, 2024

@chrisala build seems to have failed.

@chrisala
Copy link
Collaborator Author

@chrisala build seems to have failed.

This is fixed now (the test caught the extra view model only field in the payload and there was also a test ordering dependency that got exposed).

@temi temi merged commit 34f8e7b into dev Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants