-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue2880 #3352
Feature/issue2880 #3352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a big change. LGTM except for a minor comment.
} | ||
|
||
// Maintains the state of which organisation is being edited or added | ||
var selectedOrganisation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannot see this variable being used. is it supposed to be self.selectedOrganisation
?
@@ -1,232 +0,0 @@ | |||
<g:if test="${organisation.projects}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not showing projects associated with an organisation anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gsp fragement was replaced when the NHT related changes were deployed last year (with /shared/projectListByProgram) to match the management unit page behaviour - I just deleted this now as a tidy up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @temi yes, I've fix this.
@chrisala build seems to have failed. |
This is fixed now (the test caught the extra view model only field in the payload and there was also a test ordering dependency that got exposed). |
No description provided.