Improve performance of New-/Set-JiraIssue on instances with large quantities of fields

[hmmwhatsthisdo]

Description

This PR adjusts the functionality of New-JiraIssue and Set-JiraIssue to only call Get-JiraField once (if -Fields is set) instead of once per entry in the -Fields hashtable.

Additionally, both cmdlets will resolve numerical IDs for custom fields if users specify fields in that way (i.e. -Fields @{12345 = $foo} is equivalent to -Fields @{customfield_12345 = $foo})

Motivation and Context

Get-JiraField takes a -Name parameter, however the underlying API call is not filtered by name. This means that every field in the instance (visible to the current user) is retrieved for each key in -Fields. This means network traffic/CPU usage/time spent scales quadratically in practice (linear to the number of CFs in the API call and the number of CFs in the instance).

By moving Get-JiraField out of this loop (thus only calling it once), we can cache field data instead of hammering Jira's API for it.

Closes #515.

Improvement Areas

We currently query the whole instance's fields which, on larger (or poorly-organized) instances, may:

• Be very large
• Include duplicate fields used in different contexts than the user's

Using the CreateMeta and EditMeta endpoints (with Get-JiraIssueCreateMetadata and Get-JiraIssueEditMetadata) would reduce response size and limit fields to ones that are actually relevant to the current project/issue context.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• I have added Pester Tests that describe what my changes should do.
• I have updated the documentation accordingly.

[lipkau]

Fix tests

[hmmwhatsthisdo]

Fix tests

Will do, I'll give it a look this evening. Thanks for approving the CI pass!

[hmmwhatsthisdo]

@lipkau Dug into this a bit - the problem appears to be that the unit tests use a mock for Get-JiraField that only supports the field-specific implementation. New-JiraIssue appears to be easy to fix, but Set-JiraIssue might need more nuance to it.

(As an aside, it would be in our best interest to upgrade to Pester 5)

[hmmwhatsthisdo]

@lipkau Unit tests should be green again. Can you click the "Approve and run" button to re-approve running test workflows?

[lipkau]

shall we document something about further refactoring in this area?

[hmmwhatsthisdo]

shall we document something about further refactoring in this area?

@lipkau When I'm back at my desk, I can cut an issue for:

• Applying similar treatment to Invoke-JiraIssueTransition (Invoke-JiraIssueTransition hammers Jira Field API #518)
• Updating New-/Set-JiraIssue to use metadata endpoints (New-JiraIssue and Set-JiraIssue should use CreateMeta and EditMeta API endpoints for issue/field schematic info #519)
• Update to Pester 5 (Upgrade to Pester 5.x #517)

Anything else you see as being necessary here?

[hmmwhatsthisdo]

@lipkau Issues have been filed. Can you merge the PR when you have a moment?