Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .devcontainer configuration #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andoulla
Copy link
Contributor

@andoulla andoulla commented Jan 29, 2025

Description

Enable the ability to run the components repo in the remote env

Steps for opening in VS

  • In a terminal SSH into your remote env
  • Clone the repo
  • Click the green bar(it maybe blue) in the bottom-left (“Dev Container: …“) and then choose “Reopen folder in SSH”
  • Click open in container

@andoulla andoulla marked this pull request as ready for review January 29, 2025 12:26
@thomasdigby
Copy link
Member

Should we make this repo private if we're adding custom Atom dev container stuff?

@andoulla
Copy link
Contributor Author

Should we make this repo private if we're adding custom Atom dev container stuff?
@euanhunteratom what do you think?

@euanhunteratom
Copy link
Member

Should we make this repo private if we're adding custom Atom dev container stuff?
@euanhunteratom what do you think?

Not sure tbh, more of a Tim question I think. The base image and the whole remote dev setup this relies on are private and don't think there is anything particularly proprietary in the files added to this branch. Not sure what the original rational for this repo being public was to weigh against.

License wise, I see there is the GPL license under lib/ but not at the top-level. Is the intention thus that the library itself is GPL but everything else is "proprietary but source available"? Maybe want an additional License file to clarify that but IANAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants