-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Non-DICOM primary files and resources independently #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tclose
commented
Sep 26, 2024
•
edited
Loading
edited
- Non-DICOM files can be used as the primary files from which to read the project/subject/session ID information from. Just need to be implemented in FileFormats
- Stage and uploads are now check against existing files at the resource level (instead of session) for incremental uploads of session data
- Adds Discord logging
…tify and save methods. Also created ImagingResource class which handles checksums checking
…istence on resource level
tclose
force-pushed
the
flexible-formats
branch
from
September 27, 2024 12:32
d4ba8eb
to
b28669e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 78.05% 78.65% +0.60%
==========================================
Files 13 16 +3
Lines 1171 1279 +108
==========================================
+ Hits 914 1006 +92
- Misses 257 273 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.