Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Non-DICOM primary files and resources independently #21

Merged
merged 15 commits into from
Sep 28, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 26, 2024

  • Non-DICOM files can be used as the primary files from which to read the project/subject/session ID information from. Just need to be implemented in FileFormats
  • Stage and uploads are now check against existing files at the resource level (instead of session) for incremental uploads of session data
  • Adds Discord logging

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 71.35279% with 216 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (7827a91) to head (4869b92).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
xnat_ingest/upload_helpers.py 49.11% 86 Missing ⚠️
xnat_ingest/cli/upload.py 65.17% 39 Missing ⚠️
xnat_ingest/resource.py 71.71% 28 Missing ⚠️
xnat_ingest/cli/stage.py 65.51% 20 Missing ⚠️
xnat_ingest/session.py 84.76% 16 Missing ⚠️
xnat_ingest/utils.py 71.69% 15 Missing ⚠️
xnat_ingest/store.py 76.59% 11 Missing ⚠️
xnat_ingest/scan.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   78.05%   78.65%   +0.60%     
==========================================
  Files          13       16       +3     
  Lines        1171     1279     +108     
==========================================
+ Hits          914     1006      +92     
- Misses        257      273      +16     
Flag Coverage Δ
78.65% <71.35%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 68ddb1a into main Sep 28, 2024
3 of 5 checks passed
@tclose tclose deleted the flexible-formats branch October 17, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant