Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional environment vars corresponding to CLI options that didn't have them #4

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Mar 15, 2024

  • Adds envvar options to remaining CLI args for stage, transfer and upload
  • Add prefix for each commands env var so that the namespaces are separate between the commands

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (c9354f4) to head (87e87b3).
Report is 2 commits behind head on main.

Files Patch % Lines
xnat_ingest/cli/upload.py 28.94% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   73.78%   73.85%   +0.06%     
==========================================
  Files          14       14              
  Lines        1110     1109       -1     
==========================================
  Hits          819      819              
+ Misses        291      290       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit da98156 into main Mar 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant