connection: added a more intelligent callback API #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDebrunner
force-pushed
the
intelligent-callbacks
branch
from
f06f00b to
1fd11b6
Compare
| }, on_message, std::function<void(const std::exception_ptr&)>{}); | ||
| } | ||
|
|
||
| CallbackHandle addMessageCallback(const std::string &message_name, const std::function<void(const mav::Message&)> &on_message, |
There was a problem hiding this comment.
why not overload this to take an on_error exception handler too?
GuillaumeLaine
approved these changes
Mar 28, 2024
ThomasDebrunner
force-pushed
the
intelligent-callbacks
branch
4 times, most recently
from
514235f to
93e10d6
Compare
…and does not have arm stuff
ThomasDebrunner
force-pushed
the
intelligent-callbacks
branch
from
93e10d6 to
501d97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to filter for message ID, system ID and component ID when registerin callbacks like so: