Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): bytebuf leak #924

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(s3stream): bytebuf leak #924

merged 1 commit into from
Feb 6, 2024

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Feb 6, 2024

No description provided.

@superhx superhx marked this pull request as draft February 6, 2024 08:06
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (480eb04) 55.91% compared to head (8bb1fc3) 54.98%.

❗ Current head 8bb1fc3 differs from pull request most recent head d18054a. Consider uploading reports for the commit d18054a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
- Coverage     55.91%   54.98%   -0.94%     
+ Complexity     1266     1243      -23     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
- Hits           4772     4692      -80     
- Misses         3327     3425      +98     
+ Partials        435      417      -18     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (-2.81%) ⬇️
RocketMQ Proxy 37.18% <ø> (ø)
RocketMQ Store 73.60% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 16 files with indirect coverage changes

@superhx superhx force-pushed the feat_timeout_detect branch from 12cccaa to 8bb1fc3 Compare February 6, 2024 08:13
@superhx superhx marked this pull request as ready for review February 6, 2024 08:14
@superhx superhx changed the title feat(s3stream): detect read timeout fix(s3stream): bytebuf leak Feb 6, 2024
@superhx superhx force-pushed the feat_timeout_detect branch from 8bb1fc3 to d18054a Compare February 6, 2024 08:19
@ShadowySpirits ShadowySpirits merged commit 94b0216 into main Feb 6, 2024
5 checks passed
@ShadowySpirits ShadowySpirits deleted the feat_timeout_detect branch February 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants