Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): gracefully shutdown compaction manager #930

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Feb 19, 2024

@SCNieh SCNieh requested a review from superhx February 19, 2024 07:54
@SCNieh SCNieh force-pushed the compaction_shutdown branch from 4ffb596 to 17d07a7 Compare February 19, 2024 08:02
@SCNieh SCNieh force-pushed the compaction_shutdown branch from 17d07a7 to 700c785 Compare February 19, 2024 08:06
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b1cd92) 55.94% compared to head (700c785) 55.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #930      +/-   ##
============================================
- Coverage     55.94%   55.90%   -0.04%     
+ Complexity     1267     1264       -3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
- Hits           4774     4771       -3     
  Misses         3327     3327              
- Partials        433      436       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.60% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@superhx superhx merged commit e46b193 into main Feb 19, 2024
7 checks passed
@superhx superhx deleted the compaction_shutdown branch February 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stream set object compaction need graceful shutdown
2 participants