refactor(controller): consider brokers that has recently CONTROLLED_SHUTDOWN as SHUTTING_DOWN
#2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHUTDOWN` as `SHUTTING_DOWN` Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
superhx
reviewed
Jan 8, 2025
metadata/src/main/java/org/apache/kafka/controller/stream/NodeState.java
Show resolved
Hide resolved
Chillax-0v0
force-pushed
the
feat-broker-state-shutting-down
branch
from
61bbe15 to
7a34357
Compare
…and `CONTROLLED_SHUTDOWN` Signed-off-by: Ning Yu <[email protected]>
Chillax-0v0
force-pushed
the
feat-broker-state-shutting-down
branch
from
7a34357 to
100a745
Compare
superhx
approved these changes
Jan 8, 2025
Chillax-0v0
added a commit
that referenced
this pull request
Jan 8, 2025
…SHUTDOWN` as `SHUTTING_DOWN` (#2261) * refactor(controller): consider brokers that has recently `CONTROLLED_SHUTDOWN` as `SHUTTING_DOWN` Signed-off-by: Ning Yu <[email protected]> * test: test `BrokerHeartbeatManager#brokerState` Signed-off-by: Ning Yu <[email protected]> * revert(NodeState): revert `SHUTDOWN` and `SHUTTING_DOWN` to `FENCED` and `CONTROLLED_SHUTDOWN` Signed-off-by: Ning Yu <[email protected]> --------- Signed-off-by: Ning Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.