Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove aliases from state #63

Merged
merged 8 commits into from
Dec 1, 2023
Merged

refactor!: remove aliases from state #63

merged 8 commits into from
Dec 1, 2023

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Nov 30, 2023 •
edited
Loading

Description

Remove the alias functionality from the State.
Removes standard_state.model –> use standard_state.models[-1] for this case

Type of change

  • refactor: A code change that neither fixes a bug nor adds a feature

@hollandjg hollandjg changed the base branch from main to chore/set-state-dataclass-as-default November 30, 2023 20:49
@hollandjg hollandjg self-assigned this Nov 30, 2023
@hollandjg hollandjg marked this pull request as ready for review November 30, 2023 22:47
@hollandjg hollandjg added bug Something isn't working. priority 0 - emergency These can be blockers, or security issues, and should be resolved immediately. labels Nov 30, 2023
younesStrittmatter
younesStrittmatter approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god to me.

benwandrew
benwandrew approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from chore/set-state-dataclass-as-default to main December 1, 2023 21:39
@hollandjg hollandjg added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 66d03e8 Dec 1, 2023
16 checks passed
@hollandjg hollandjg deleted the chore/remove-aliases-from-state branch December 1, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesStrittmatter younesStrittmatter younesStrittmatter approved these changes

@benwandrew benwandrew benwandrew approved these changes

@musslick musslick Awaiting requested review from musslick

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

@TheLemonPig TheLemonPig Awaiting requested review from TheLemonPig

@whyhardt whyhardt Awaiting requested review from whyhardt

Assignees

@hollandjg hollandjg

Labels
bug Something isn't working. priority 0 - emergency These can be blockers, or security issues, and should be resolved immediately.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: remove aliases from state.py
3 participants
@hollandjg @benwandrew @younesStrittmatter