EMSUSD-1017 Fix reverting multiple files #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1017/fix-multi-revert-crash
branch
from
cbd8e12 to
96feace
Compare
When reverting multiple USD layers, reverting the first layer would trigger the UI to update, thus making the the element holding the other layers invalid before they were processed. To avoid this, add a mechanism to delay the execution of commands in the command-hook so that all item can be processed before the first command is executed. In the Maya implementation of the command hook, the MEL and Python commands are accumulated when the commands are delayed and executed once the delayed commands are triggered.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1017/fix-multi-revert-crash
branch
from
96feace to
31620d7
Compare
| } | ||
| } | ||
|
|
||
| void MayaCommandHook::executeDelayedCommands() |
There was a problem hiding this comment.
Would you mind adding a comment that this function should not be called directly?
| MGlobal::executeCommand( | ||
| MString(commandString.c_str()), | ||
| result, | ||
| /*display*/ true, |
There was a problem hiding this comment.
Do we always want to have display on?
There was a problem hiding this comment.
It was like that in the existing code that I moved here from the top of the file.
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reverting multiple USD layers, reverting the first layer would trigger the UI to update, thus making the the element holding the other layers invalid before they were processed.
To avoid this, add a mechanism to delay the execution of commands in the command-hook so that all item can be processed before the first command is executed.
In the Maya implementation of the command hook, the MEL and Python commands are accumulated when the commands are delayed and executed once the delayed commands are triggered.