EMSUSD-1896 avoid crash when shader has no uvLink #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
The uvLink command can return nothing if it cannot determine the UV link of the shader node. This would break assumptions in the export code and lead to a crash when accessing missing data. Handle the case where the uvLink command returns nothing to prevent that crash. Add a unit test that reproduced the crash and now no longer crashes.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1896/export-shader-crash
branch
from
ed52c58 to
135f140
Compare
JGamache-autodesk
approved these changes
Feb 25, 2025
|
The changes are good? I was unsure how to best handle the missing uvLink. I was wondering if maybe the command did not support the connected node? It might be worth digging into this further in the future? For now, all I wanted was to at least avid the crash. |
|
A slightly better fix would be to pick the first UV set available on the geometry if there is any, but I am perfectly happy with "not crashing, no UV" when using exotic nodes like that doubleSwitch. |
|
There were UV in the resulting file for that node. The UV were not replaced by that "largest" one. |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uvLink command can return nothing if it cannot determine the UV link of the shader node. This would break assumptions in the export code and lead to a crash when accessing missing data. Handle the case where the uvLink command returns nothing to prevent that crash.
Add a unit test that reproduced the crash and now no longer crashes.