Add PowerShell command to setup Windows environment #100
Conversation
mokagio
force-pushed
the
mokagio/windows-utils
branch
from
92062e0 to
6f010f1
Compare
| $(docker_run) koalaman/shellcheck hooks/** bin/** --exclude=SC1071 | ||
| $(docker_run) koalaman/shellcheck $(shell find hooks bin -type f -not -name "*.ps1") --exclude=SC1071 |
There was a problem hiding this comment.
👍
(I wonder if there's a shellcheck equivalent for PowerShell btw… though probably only a thing to look at when we'll start tacking #101 more officially/broadly?)
There was a problem hiding this comment.
I wonder if there's a shellcheck equivalent for PowerShell btw…
Found this… in case we want to look into it at some point
| context 'All Commands Should Be Executable' do | ||
| Dir.children('bin').map { |f| File.new(File.join('bin', f)) }.each do |file| | ||
| it file.path do | ||
| expect(file.stat.executable?).to be true | ||
| context 'All Unix Commands Should Be Executable' do | ||
| Dir | ||
| .children('bin') | ||
| # Ignore Windows PowerShell scripts | ||
| .reject { |f| f.end_with?('.ps1') } |
mokagio
force-pushed
the
mokagio/windows-utils
branch
from
2c0b1d1 to
e36edc3
Compare
Generated by 🚫 Danger |
Even if one runs `chmod u+x` on the file, the test fails. Anyways, we don't care about PowerShell being executable from a Unix point of view, because they should be used only under Windows.
I usually use Vim for Ruby files, where I have RuboCop configured. Today, I used VS Code, where I _should have_ configured RuboCop but evidently have not.
Context: I tried calling `add_ssh_key_to_agent` straight from the Windows environment but it didn't work.
`LocalMachine` might not be allowed at a access right level. See how this build failed https://buildkite.com/automattic/beeper-desktop/builds/2897#0191979b-a067-4780-8a45-f051515841f1
Doesn't work! ChatGPT what are you suggesting?! https://buildkite.com/automattic/beeper-desktop/builds/2901#019197e0-da5d-47ec-84ec-8327b4aa5c7c/273-279
Seems like all the flags did not make any difference in terms of whether the symlink creation was attempted. E.g. This build failed with the same symlink error as before, despite having the flags https://buildkite.com/automattic/beeper-desktop/builds/2907#0191982e-d1c5-402f-99be-2299321ccbe6
mokagio
force-pushed
the
mokagio/windows-utils
branch
from
034091f to
43653a0
Compare
mokagio
force-pushed
the
mokagio/windows-utils
branch
from
43653a0 to
647299c
Compare
|
After months of this sitting here approved but with the tests failing, I finally got down to fixing it. The reason for the test failure, i.e. for the new See how 647299c fixes the I did a bit of force pushing to rebase this branch on Given the only effective change since @AliSoftware approved this was changing the executable status of the The context for getting onto this change is that we'll need to set up Windows CI on the new Day One Electron app soon. I'm ready to jump on it, but I'd prefer if someone else had a go, to reduce the bus factor. With that in mind, it seemed appropriate to at least help and remove the oddity of having to use a custom branch in the CI setup. |
|
I restored the branch so builds referencing it won't fail while we transition them to a stable version. |
|
@mokagio you might also want to add a CHANGELOG entry for this PR in a follow-up on before doing the next tag/release of this plugin |
CHANGELOG.mdif necessary.