This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
CampTix Tools: Add placeholder in Purchase date field. #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymckrill
suggested changes
Aug 22, 2019
There was a problem hiding this comment.
Thanks for the PR @donmhico
This was discussed in our bug scrub today:
https://wordpress.slack.com/archives/C08M59V3P/p1566493484129300
The summary is, let's remove the unconnected screen reader text (see inline comment below) and then this is ready to go.
camptix.php
Outdated
| <input placeholder="{{ data.placeholder }}" type="text" class="segment-value regular-text" value="{{ data.model.value }}" /> | ||
| <# if ( data.placeholder.length > 0 ) { #> | ||
| <span class="screen-reader-text">{{ data.placeholder }}</span> | ||
| <# } #> |
There was a problem hiding this comment.
Since this screen reader text element isn't actually linked to the input, it may not be that useful. For now, I'd say let's remove it, and in a separate PR we could try implementing proper <label> elements for this form, and perhaps other accessibility improvements.
There was a problem hiding this comment.
Thanks for the review @coreymckrill. I've amended the commit that reflects the changes you requested.
donmhico
force-pushed
the
meta-trac-4056
branch
from
bd50698
to
d5dcb57
Compare
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes - https://meta.trac.wordpress.org/ticket/4056.