Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copy-pasting more discoverable #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simison
Copy link
Member

@simison simison commented May 10, 2019

  • abstract to a function:
    • provides a place to explain what id is for
    • less repetition
  • add hover/active colors for some visual feedback
  • add title attribute to tell users can click and copy 🎉

jn-click

- abstract to a function:
  - provides a place to explain what `id` is for
  - less repetition
- add hover/active colors
- add `title` attribute
@simison simison requested review from oskosk and brbrr May 10, 2019 11:52
@brbrr
Copy link
Contributor

brbrr commented Feb 7, 2022

Ouch! missed the ping 😅

@osk what do you think? Should we bring it home? (after rebase and stuff)

@simison
Copy link
Member Author

simison commented Feb 7, 2022

Oh wow oldie. :-D

BTW just adding simple icon at the end of text which does the copying seems easiest to add, and clearest for everyone to realise what it does. Example from Github:

Screen.Recording.2022-02-07.at.12.23.02.mov

(Tho the tooltip is nice I don't think it's really needed)

Icon svg could be: https://fonts.google.com/icons?selected=Material%20Icons%3Acontent_paste%3A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants