Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Falsely flagging using past tense and suggesting present tense #581

Closed
hippietrail opened this issue Feb 3, 2025 · 0 comments · Fixed by #589
Closed

bug: Falsely flagging using past tense and suggesting present tense #581

hippietrail opened this issue Feb 3, 2025 · 0 comments · Fixed by #589
Labels
bug Something isn't working

Comments

@hippietrail
Copy link
Contributor

Describe the bug
Correct uses of "made a decision" in the past tense are being flagged and suggesting the present tense "make a decision" when it doesn't make sense.

To Reproduce
Steps to reproduce the behavior:

  1. Type in 'We finally made a decision.'
  2. Notice 'made a decision' has a squiggly underneath it.
  3. Notice 'Did you mean the phrase make a decision?' is suggested as a correction.

Expected behavior
Nothing should be flagged in this sentence. Tenses should not be changed except maybe in very specific circumstances and contexts.

Screenshots

Image

Platform
harper-ls, VS Code

@hippietrail hippietrail added the bug Something isn't working label Feb 3, 2025
elijah-potter added a commit that referenced this issue Feb 4, 2025
@elijah-potter elijah-potter linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant