Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrase fixes #589

Merged
merged 9 commits into from
Feb 5, 2025
Merged

Phrase fixes #589

merged 9 commits into from
Feb 5, 2025

Conversation

elijah-potter
Copy link
Collaborator

@elijah-potter elijah-potter commented Feb 4, 2025

Incorporated additional feedback from #550.

Resolves #582, #581, and #574.

@ccoVeille
Copy link
Contributor

I have just found out this PR

I wonder if it doesn't solve #600 I have just created to avoid missing the one reported in #550

@elijah-potter
Copy link
Collaborator Author

I don't think it covers all of #600, since there are a lot of things in your list that can be ambiguous depending on broader context (for example pour over to pore over). This PR can't handle those more complex cases.

@elijah-potter elijah-potter merged commit f62035e into master Feb 5, 2025
17 checks passed
@elijah-potter elijah-potter deleted the phrase-fixes branch February 5, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants