Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve workflow for harper.js #526

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

Asuka109
Copy link
Contributor

@Asuka109 Asuka109 commented Jan 28, 2025

This pull request includes several changes to improve compatibility and simplify the codebase. The most important changes involve updating the node version, switching from sed to perl for text replacement, and modifying the import statement in an example script.

The original sed statement will cause the error below:

> just setup                                                           
warning: /Users/asuka109/repositories/harper/harper-cli/Cargo.toml: unused manifest key: package.private
warning: /Users/asuka109/repositories/harper/harper-wasm/Cargo.toml: unused manifest key: package.private
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s
cd "/Users/asuka109/repositories/harper/harper-wasm" && wasm-pack build --target web
[INFO]: 🎯  Checking for the Wasm target...
[INFO]: 🌀  Compiling to Wasm...
warning: /Users/asuka109/repositories/harper/harper-wasm/Cargo.toml: unused manifest key: package.private
warning: /Users/asuka109/repositories/harper/harper-cli/Cargo.toml: unused manifest key: package.private
    Finished `release` profile [optimized] target(s) in 0.07s
[INFO]: ⬇️  Installing wasm-bindgen...
[INFO]: Optimizing wasm binaries with `wasm-opt`...
[INFO]: Optional fields missing from Cargo.toml: 'description', 'license'. These are not necessary, but recommended
[INFO]: ✨   Done in 16.55s
[INFO]: 📦   Your wasm pkg is ready to publish at /Users/asuka109/repositories/harper/harper-wasm/pkg.
sed: 1: "/Users/asuka109/reposit ...": command a expects \ followed by text
error: Recipe `build-harperjs` failed with exit code 1

@Asuka109 Asuka109 changed the title fix: macos setup [WIP]fix: macos setup Jan 28, 2025
@Asuka109 Asuka109 marked this pull request as draft January 28, 2025 05:43
@Asuka109 Asuka109 changed the title [WIP]fix: macos setup feat: improve workflow for harper.js Jan 28, 2025
@Asuka109 Asuka109 marked this pull request as ready for review January 28, 2025 10:50
@Asuka109
Copy link
Contributor Author

Hi @elijah-potter! I encountered some issues while setup the project, so I created this PR to fix them. Could you please help to review it?

@elijah-potter
Copy link
Collaborator

This looks great! @Asuka109, thank you for fixing the problems for MacOS. I develop primarily on Linux, so I wasn't even aware there were issues 😄.

Just one thing before I can merge: would you mind modifying the GitHub Actions workflows to use the new .node-version file? It would be cool to have it centralized.

@Asuka109
Copy link
Contributor Author

Asuka109 commented Jan 28, 2025

@elijah-potter Done~

@elijah-potter
Copy link
Collaborator

Looks great! Merging...

@elijah-potter elijah-potter merged commit e5548ae into Automattic:master Jan 28, 2025
17 checks passed
@Asuka109 Asuka109 deleted the feat/macos-contributing branch January 29, 2025 06:07
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 29, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | patch | `v0.18.0` -> `v0.18.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.18.1`](https://github.com/Automattic/harper/releases/tag/v0.18.1)

[Compare Source](Automattic/harper@v0.18.0...v0.18.1)

#### What's Changed

-   build(deps): bump [@&#8203;sveltepress/theme-default](https://github.com/sveltepress/theme-default) from 5.0.5 to 5.0.7 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#519
-   build(deps-dev): bump eslint-config-prettier from 9.1.0 to 10.0.1 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#518
-   build(deps-dev): bump vite-plugin-top-level-await from 1.4.1 to 1.4.4 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#516
-   build(deps-dev): bump esbuild from 0.20.2 to 0.24.2 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#517
-   build(deps-dev): bump flowbite from 1.8.1 to 3.0.0 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#515
-   technical terms and popular names/websites by [@&#8203;MohamedAbdeen21](https://github.com/MohamedAbdeen21) in Automattic/harper#522
-   fix(core): `AnA` linter did not recognize capital articles by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#521
-   use unicode_script crate to check chars are Latin script inside `is_english_lingual` by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#504
-   sort and add to list of holidays by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#509
-   fix(core): `RepeatedWords` now detects repeated `and` tokens by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#520
-   `harper-core` Documentation Updates by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#513
-   feat: improve workflow for harper.js by [@&#8203;Asuka109](https://github.com/Asuka109) in Automattic/harper#526
-   Add more languages by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#495

#### New Contributors

-   [@&#8203;MohamedAbdeen21](https://github.com/MohamedAbdeen21) made their first contribution in Automattic/harper#522
-   [@&#8203;Asuka109](https://github.com/Asuka109) made their first contribution in Automattic/harper#526

**Full Changelog**: Automattic/harper@v0.18.0...v0.18.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMiIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants