Skip to content

[DONT MERGE] WIP POC for refactoring #47255

[DONT MERGE] WIP POC for refactoring

[DONT MERGE] WIP POC for refactoring #47255

Triggered via pull request November 8, 2023 12:48
Status Failure
Total duration 2m 49s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

linting.yml

on: pull_request
detect changed files
11s
detect changed files
Copied files are in sync
8s
Copied files are in sync
Changelogger use
29s
Changelogger use
Changelogger validity
53s
Changelogger validity
Project structure
1m 44s
Project structure
PHP Code Sniffer (non-excluded files only)
1m 36s
PHP Code Sniffer (non-excluded files only)
PHP Compatibility
1m 39s
PHP Compatibility
PHP Code Sniffer (changes to excluded files only)
0s
PHP Code Sniffer (changes to excluded files only)
ESLint (non-excluded files only)
2m 0s
ESLint (non-excluded files only)
ESLint (changes to excluded files only)
0s
ESLint (changes to excluded files only)
Lint GitHub Actions yaml files
0s
Lint GitHub Actions yaml files
Check linter exclude lists
0s
Check linter exclude lists
Lock files are up to date
0s
Lock files are up to date
Monorepo package version refs
0s
Monorepo package version refs
Matrix: php_lint
Fit to window
Zoom out
Zoom in

Annotations

21 errors and 20 warnings
Changelogger validity: projects/packages/publicize/package.json#L4
Version mismatch, expected 0.36.6-alpha but found 0.36.5! You might use `tools/project-version.sh -f -u 0.36.6-alpha packages/publicize` or `tools/fixup-project-versions.sh` to fix this.
Changelogger validity
Process completed with exit code 1.
PHP lint (5.6): projects/plugins/social/src/class-jetpack-social.php#L268
Parse error: syntax error, unexpected ')'
PHP lint (5.6)
Process completed with exit code 1.
PHP lint (7.2): projects/plugins/social/src/class-jetpack-social.php#L268
Parse error: syntax error, unexpected ')'
PHP lint (7.2)
Process completed with exit code 1.
PHP lint (7.0): projects/plugins/social/src/class-jetpack-social.php#L268
Parse error: syntax error, unexpected ')'
PHP lint (7.0)
Process completed with exit code 1.
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L150
There should be a comma after the last array item in a multi-line array. (NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L151
There should be a comma after the last array item in a multi-line array. (NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L15
Spaces must be used for mid-line alignment; tabs are not allowed (Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L16
Spaces must be used for mid-line alignment; tabs are not allowed (Universal.WhiteSpace.DisallowInlineTabs.NonIndentTabsUsed)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L39
Array keys must NOT be surrounded by spaces if they only contain a string or an integer. (WordPress.Arrays.ArrayKeySpacingRestrictions.SpacesAroundArrayKeys)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L66
There should be a comma after the last array item in a multi-line array. (NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLine)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L69
Whitespace found at end of line (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L86
Missing doc comment for function update_settings() (Squiz.Commenting.FunctionComment.Missing)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L86
Expected 1 spaces before closing parenthesis; 0 found (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L91
Missing doc comment for function update_auto_conversion_settings() (Squiz.Commenting.FunctionComment.Missing)
PHP Compatibility: projects/plugins/social/src/class-jetpack-social.php#L267
Trailing comma's are not allowed in function calls in PHP 7.2 or earlier (PHPCompatibility.Syntax.NewFunctionCallTrailingComma.FoundInFunctionCall)
PHP Compatibility
Process completed with exit code 1.
ESLint (non-excluded files only)
Process completed with exit code 1.
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L10
Use statements are not alphabetically sorted (MediaWiki.Classes.UnsortedUseStatements.UnsortedUse)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L51
Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L52
Equals sign not aligned with surrounding assignments; expected 1 space but found 3 spaces (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-rest-settings-controller.php#L106
Array double arrow not aligned correctly; expected 7 space(s) between "'autoConversionSettings'" and double arrow, but found 1. (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L10
Unused use statement "Modules" (MediaWiki.Classes.UnusedUseStatement.UnusedUse)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/jetpack-social-settings/class-settings.php#L71
Array double arrow not aligned correctly; expected 7 space(s) between "'autoConversionSettings'" and double arrow, but found 1. (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
PHP Code Sniffer (non-excluded files only): projects/packages/publicize/src/class-publicize-setup.php#L45
This comment is 59% valid code; is this commented out code? (Squiz.PHP.CommentedOutCode.Found)
PHP Code Sniffer (non-excluded files only): projects/plugins/social/src/class-jetpack-social.php#L233
Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)
PHP Code Sniffer (non-excluded files only): projects/plugins/social/src/class-jetpack-social.php#L238
Array double arrow not aligned correctly; expected 1 space(s) between "'jetpackSettings'" and double arrow, but found 14. (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
PHP Code Sniffer (non-excluded files only): projects/plugins/social/src/class-jetpack-social.php#L248
Array double arrow not aligned correctly; expected 2 space(s) between "'connectionData'" and double arrow, but found 15. (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)