Skip to content

Commit

Permalink
Fix Newsletter byline link font-size and icon (#38591)
Browse files Browse the repository at this point in the history
* ExternalLink instead of JetpackButton

* changelog

* Remove variant and isExternalLink props

* Remove comments
  • Loading branch information
crisbusquets authored Jul 29, 2024
1 parent 1520638 commit 748e9f1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
Chip,
Button as JetpackButton,
} from '@automattic/jetpack-components';
import { ExternalLink } from '@wordpress/components';
import { createInterpolateElement } from '@wordpress/element';
import { __, sprintf } from '@wordpress/i18n';
import Button from 'components/button';
Expand Down Expand Up @@ -307,13 +308,7 @@ const EmailSettings = props => {
'jetpack'
),
{
settingsLink: (
<JetpackButton
variant="link"
isExternalLink={ true }
href={ adminUrl + 'options-general.php' }
/>
),
settingsLink: <ExternalLink href={ adminUrl + 'options-general.php' } />,
}
) }
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: other
Comment: Tiny font-size update


0 comments on commit 748e9f1

Please sign in to comment.