Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Protect card Threats tooltip styles/content issues #40433

Closed
dkmyta opened this issue Dec 3, 2024 · 1 comment · Fixed by #40691
Closed

My Jetpack: Protect card Threats tooltip styles/content issues #40433

dkmyta opened this issue Dec 3, 2024 · 1 comment · Fixed by #40691
Assignees
Labels
[Package] My Jetpack [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dkmyta
Copy link
Contributor

dkmyta commented Dec 3, 2024

Impacted plugin

My Jetpack - Jetpack, Protect

Quick summary

  • The threats tooltip styles do not appear to be applied.
  • The logic for the tooltip text is incorrect, in the case of the image below I had 6 threats, 1 of which was critical - the wording suggests I have 6 critical threats.
  • IMO the content here could be improved:
    • threat.. should either be threats... (a full ellipsis) or threats.(the end of the sentence).
    • The final portion of the text may be a little misleading:
      • Not all threats are auto-fixable.
      • The use of in the product is not an especially clear directive.

Image

Steps to reproduce

  1. Install/activate Jetpack Protect with a Scan upgrade
  2. Add various severity threats using the Scan Helper in the Jetpack Debug Tool
  3. Run a scan to detect them
  4. Proceed to the My Jetpack section
  5. Hover over the icon to the right of the term Threats to view the tooltip
  6. Note that I have only tested this particular scenario, its unclear if the issues persist in other card states

A clear and concise description of what you expected to happen.

The Threats tooltip should be styled similar to the others and the content should be accurate, clear, and concise.

What actually happened

See image provided in main description.

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@dkmyta dkmyta added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Dec 3, 2024
@github-actions github-actions bot added [Pri] High [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Protect Also known as Brute Force Attack Protection [Feature] Scan labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue is related to the display and management of content within the Jetpack Protect tooltip system.
  • [Feature] Protect: This issue is specifically linked to the Jetpack Protect feature, which is responsible for threat detection.
  • [Feature] Scan: The problem involves the scanning tool, which identifies threats and their severity, impacting the tooltip display.

@matticbot matticbot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Dec 3, 2024
@jeherve jeherve added [Pri] Normal Triaged and removed [Pri] High Needs triage Ticket needs to be triaged labels Dec 4, 2024
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 4, 2024
@jeherve jeherve added [Package] My Jetpack and removed [Feature] Protect Also known as Brute Force Attack Protection [Feature] Scan [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Experiment] AI labels added [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. labels Dec 4, 2024
@augurlu augurlu assigned augurlu and elliottprogrammer and unassigned augurlu Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

5 participants