Protect Status: Refactor data handling

[nateweller]

Proposed changes:

• Improves the data handling in the protect-status package.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Check CLI tests.
• Smoke test implementing features:
  • Protect status card in My Jetpack
  • Protect plugin scan results

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the refactor/protect-status branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack refactor/protect-status
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[dkmyta]

LGTM!

Question - should this go into our project branch or should it go straight into trunk?

Noticed something about the card in My Jetpack, specifically regarding the styling and wording of the Threats tooltip:

• First off, obviously the style is awkward here.
• Second, The last scan identified 6 critical threats.. But don’t worry, use the “Auto-fix” button in the product to automatically fix most threats.
  • There is only 1 critical threat
  • Thinking that should be ...
  • The wording is slightly misleading about the Auto-fix

Is this our responsibility to improve/maintain?

[nateweller]

Thanks @dkmyta! 😄

Question - should this go into our project branch or should it go straight into trunk?

This can go into trunk, as it is a backwards compatible enhancement 👍

Noticed something about the card in My Jetpack, specifically regarding the styling and wording of the Threats tooltip

I would ask Jetpack Martech or submit an issue to be triaged.

[dkmyta]

I would ask Jetpack Martech or submit an issue to be triaged.

Reported the issue here.