Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Increase PHP memory limit #34017

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 8, 2023

Proposed changes:

Some wp-cli calls, including in the Post-Build CI workflow, are starting to hit the old limit. Let's increase it.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1699451690173129/1699443188.713519-slack-C034JEXD1RD
p1699444736890009-slack-CDLH4C1UZ

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is the Post-Build workflow happy now?

Some wp-cli calls, including in the Post-Build CI workflow, are starting
to hit the old limit. Let's increase it.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] High labels Nov 8, 2023
@anomiex anomiex requested a review from a team November 8, 2023 14:38
@anomiex anomiex self-assigned this Nov 8, 2023
@anomiex anomiex enabled auto-merge (squash) November 8, 2023 14:38
@github-actions github-actions bot added the Docker label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jeherve
jeherve previously approved these changes Nov 8, 2023
gmjuhasz
gmjuhasz previously approved these changes Nov 8, 2023
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see if it solves the Post-Build action, but this solved my memory issues with the jetpack docker wp commands after reinstalling. Thanks Brad! 👍

@jeherve jeherve dismissed stale reviews from gmjuhasz and themself via b6153a3 November 8, 2023 14:48
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 8, 2023
@github-actions github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin labels Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/docker-php-memory-limit branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/docker-php-memory-limit
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/docker-php-memory-limit
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@anomiex anomiex disabled auto-merge November 8, 2023 14:58
@anomiex anomiex merged commit a3fd08e into trunk Nov 8, 2023
53 of 54 checks passed
@anomiex anomiex deleted the update/docker-php-memory-limit branch November 8, 2023 15:16
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker [Package] Jetpack mu wpcom WordPress.com Features [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Pri] High [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants