Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: add missing textdomain #34577

Closed
wants to merge 1 commit into from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 11, 2023

Proposed changes:

Follow-up to #34173

The textdomain is mandatory when declaring a new script; let's add it here to avoid warnings in our logs.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Epic: #33853

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Open your error logs
  • Go to the feedback menu in wp-admin
  • Note the errors filling in your logs.
  • Apply this branch.
  • Refresh the page; no new errors should appear.

Follow-up to #34173

The textdomain is mandatory when declaring a new script; let's add it here to avoid warnings in our logs.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal [Status] Needs Team Review labels Dec 11, 2023
@jeherve jeherve requested a review from monsieur-z December 11, 2023 17:16
@jeherve jeherve self-assigned this Dec 11, 2023
@jeherve jeherve enabled auto-merge (squash) December 11, 2023 17:16
Copy link
Contributor

github-actions bot commented Dec 11, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/contact-form-a11y-script-textdomain branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/contact-form-a11y-script-textdomain
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex
Copy link
Contributor

anomiex commented Dec 11, 2023

The changes from #34520 that this was fixing were reverted in #34583. Details in p1702319188883389-slack-CBG1CP4EN.

@anomiex anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 11, 2023
@jeherve jeherve closed this Dec 12, 2023
auto-merge was automatically disabled December 12, 2023 08:19

Pull request was closed

@github-actions github-actions bot removed [Status] Needs Team Review [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants