-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Assistant: Add chat history to inline extension #37429
AI Assistant: Add chat history to inline extension #37429
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the code and did more than 10 interactions to check how the 20-messages cap was going to work.
I confirmed that:
- each request adds the previous response and a new message on the array
- the responses make sense
- the content of the heading can be edited and the new version is considered by the Assistant
The history works in a nice way. I tested multiple translations, tone changes, adding and removing emojis, than asked to revert to the original language (it worked), asked to add back the first emoji we tried (it worked), even when I updated the heading myself.
Really nice work!
…line-extension-heading-history
Fixes #37410
Fixes #37428
Depends on D149047-code
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
To be tested with D149047-code
An example of history that was not possible before:
Translate to: Portuguese.
Scratch that, go back to how it was before, but in all caps