Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Cache: add an admin notice to encourage migration to Jetpack Boost #37840

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
11e4508
Auto styling by VScode.
donnchawp Jun 13, 2024
0c824eb
Style the "Migrate now" button
donnchawp Jun 13, 2024
da97151
Display an admin notice to migrate to Boost
donnchawp Jun 13, 2024
3fbff69
changelog
donnchawp Jun 13, 2024
ccb63f0
Add an ID to the jetpack form EU cookie law form tag (#37839)
jdevalk Jun 13, 2024
751febd
Sync: fix typo (#37841)
jeherve Jun 13, 2024
4e1fe65
Boost: Updates for 3.4.2 release (#37842)
dilirity Jun 13, 2024
ca97348
Like Block: Fix styling conflicts and update editor styles (#37719)
ivan-ottinger Jun 13, 2024
fb4078f
Nav Redesign: Drop the early access and is_proxied. (#37845)
zinigor Jun 13, 2024
142c5db
Remove code to replace "Site visibility" with a link to Calypso. (#37…
zinigor Jun 13, 2024
80fd5ad
Revert adding overview menu option. (#37844)
zinigor Jun 13, 2024
eb44d12
Boost: Backport changes from 3.4.2/ init new plugin cycle (#37846)
dilirity Jun 13, 2024
737253c
Super Cache: notify Boost that migration is in progress (#37797)
donnchawp Jun 13, 2024
a612be4
Super Cache: Make sure plugin links is an array before using it (#37604)
donnchawp Jun 13, 2024
9742c21
Backport Changes (#37847)
zinigor Jun 13, 2024
c4efc08
AI Assistant: Hide input when user types on extended block (#37801)
dhasilva Jun 13, 2024
20e27d1
Top Posts & Pages Block: Prevent Disabling all Types (#36305)
Aurorum Jun 13, 2024
efb7307
Updates wpcomsh to sync with version 3.22.13. (#37848)
zinigor Jun 13, 2024
abcc5fc
Jetpack AI Image: implement "insert image" action (#37834)
lhkowalski Jun 13, 2024
5ab2288
Changelog and readme.txt edits. (#37856)
zinigor Jun 13, 2024
db0c5c7
wpcomsh: Fix PHP 8 fatal on managed plugins (#37849)
tbradsha Jun 13, 2024
89daed8
Social Logos: Rewrite svg-optimize script in JS (#37831)
tbradsha Jun 13, 2024
75006fc
Change the wpcomsh project composer slug. (#37861)
zinigor Jun 13, 2024
4cfe43b
ci: Use `beta-plugin-slug` in autorelease action (#37863)
anomiex Jun 13, 2024
99625fe
Update Size-limit to v11 (major) (#37860)
matticbot Jun 13, 2024
7d66961
eslint-config-target-es: Support flat config (eslint v9) (#37855)
anomiex Jun 13, 2024
2f5d708
Simple Classic: Release it using wpcom function besides the option (#…
lupus2k Jun 14, 2024
af53dab
Fix site management panel widget link (#37868)
candy02058912 Jun 14, 2024
d1a9e01
Boost: Include missing dependency (#37873)
haqadn Jun 14, 2024
93732ef
Changelog and readme.txt edits. (#37871)
candy02058912 Jun 14, 2024
7e050db
Social: Fix admin pricing table not shown (#37877)
manzoorwanijk Jun 14, 2024
4716969
Fix E2E tests navigating to block editor (#37875)
manzoorwanijk Jun 14, 2024
74a1c8b
Boost: backport 3.4.3 (#37874)
dilirity Jun 14, 2024
4f7bae9
Profile Behavior: Remove bi-directional syncing (#37862)
DustyReagan Jun 14, 2024
8fafd73
cli: Fix rsync of unpublished plugins to plugins dir (#37879)
anomiex Jun 14, 2024
73e0992
A4A Client Plugin: update author URL (#37876)
jeherve Jun 14, 2024
37cb6fd
Update All Sites icon size for Simple Classic (#37832)
lupus2k Jun 14, 2024
c20dbcc
Remove status check images from the wpcomsh README.md. (#37881)
zinigor Jun 14, 2024
18bd944
Docs: Updating the Git Workflow docs to explain how to update an exte…
coder-karen Jun 14, 2024
bd01379
Do not force VS Code settings (#37498)
tbradsha Jun 14, 2024
c533aa4
Update conditionally render connection footer with unlock (#37802)
CodeyGuyDylan Jun 14, 2024
5ce0f85
Update show tooltip on card hover (#37858)
CodeyGuyDylan Jun 14, 2024
4d7f2f2
Update connection status tests to typescript (#37829)
CodeyGuyDylan Jun 14, 2024
8d52d56
Changelog and readme.txt edits. (#37882)
zinigor Jun 14, 2024
8749d20
ci: Handle multiple artifacts in post-build workflow (#37884)
anomiex Jun 14, 2024
871ae37
Remove redundant bin scripts in the wpcomsh plugin. (#37880)
zinigor Jun 14, 2024
92100ce
Add scan team members to Jetpack contributors list (#37804)
nateweller Jun 14, 2024
91ec074
Update minimum composer version (#37886)
anomiex Jun 14, 2024
8748194
Move the Protect plugin models into it's own package. (#37864)
elliottprogrammer Jun 14, 2024
f35cd7f
Jetpack admin-menu endpoint: Require masterbar menu load file only on…
fgiannar Jun 17, 2024
cd21d87
Super Cache: use "activate/install boost button" on the banner in oth…
donnchawp Jun 17, 2024
f68e69f
Social: Fix Reconnect link for broken connections in the editor from …
manzoorwanijk Jun 17, 2024
70322ef
Social : Update connections management links for classic editor (#37681)
manzoorwanijk Jun 17, 2024
1073a93
wpcomsh: Update WooCommerce Calypso Bridge to 2.5.2 (#37883)
ivan-ottinger Jun 17, 2024
149908d
renovate: Fix warnings from weird wpcomsh deps (#37885)
anomiex Jun 17, 2024
a7bd976
Add the weekly branch prefix to wpcomsh. (#37857)
zinigor Jun 17, 2024
cc68d72
Disable WP.com custom editor navigation bar (#37893)
zinigor Jun 17, 2024
a666c94
User Content Link Tracking: check blog_id before link redirection (#3…
JuanLucha Jun 17, 2024
ee9aedc
Super Cache: check for the same Boost that the plugin later tries to …
donnchawp Jun 17, 2024
5c943af
Backport mu-wpcom-plugin 2.1.33, jetpack 13.6-a.3, wpcomsh 3.22.15 Ch…
zinigor Jun 17, 2024
1648d85
Revert "ExPlat: introduce empty JS package (#37655)" (#37887)
IanRamosC Jun 17, 2024
f6858da
Amended the wpcomsh plugin readme file. (#37901)
zinigor Jun 17, 2024
b70c84c
Changelog and readme.txt edits. (#37905)
zinigor Jun 17, 2024
30a5303
Remove/check for broken modules red bubble slug (#37911)
CodeyGuyDylan Jun 17, 2024
06837ae
My Jetpack: Portback after my-jetpack release (#37915)
haqadn Jun 18, 2024
b292f59
Stats: Check if Jetpack is integrated with the Complianz plugin to sh…
dognose24 Jun 18, 2024
1ac3a62
Social: Backport changes frome the 4.5.1 release (#37917)
pablinos Jun 18, 2024
d1e11df
Merge branch 'add/super-cache/admin-notice-boost' of github.com:Autom…
donnchawp Jun 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/actions/tool-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ runs:

if [[ "${INPUT_PHP:-$PHP_VERSION}" == 7.[01] ]]; then
printf "Downgrading composer for PHP %s\n\n" "${INPUT_PHP:-$PHP_VERSION}"
COMPOSER_VERSION=2.2.23
COMPOSER_VERSION=2.2.24
fi

printf "\n\e[1mSelected tool versions\e[0m\n"
Expand Down
2 changes: 1 addition & 1 deletion .github/files/gh-autorelease/files/autorelease.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if [[ ! -f composer.json ]]; then
exit 1
fi

SLUG="$(jq -r '.extra.autorelease.slug? // .extra["wp-plugin-slug"] // ( .name | sub( "^.*/"; "" ) )' composer.json)"
SLUG="$(jq -r '.extra.autorelease.slug? // .extra["wp-plugin-slug"] // .extra["beta-plugin-slug"] // ( .name | sub( "^.*/"; "" ) )' composer.json)"
if [[ -z "$SLUG" ]]; then
echo '::error::Failed to get slug from composer.json.'
exit 1
Expand Down
35 changes: 35 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@
// Monorepo packages are excluded in renovate-config.js, where we can read
// the list of them in code.

// Disable the packagist 'wordpress/classic-editor-plugin'. It's not in packagist, and we have a customManager for it below.
{
matchDatasources: [ 'packagist' ],
matchDepNames: [ 'wordpress/classic-editor-plugin' ],
enabled: false,
},

// Widen PHP dev deps to maintain support for old PHP versions we still support.
// When we drop an old PHP version we'll manually go through and narrow any ranges.
// (non-dev deps are handled in renovate-config.js where we can read the correct value for `constraints.php`)
Expand Down Expand Up @@ -106,7 +113,35 @@
depNameTemplate: 'renovate',
packageNameTemplate: 'ghcr.io/renovatebot/renovate',
},

// wpcomsh's wordpress/classic-editor-plugin fake-package.
{
customType: 'regex',
fileMatch: [ '^projects/plugins/wpcomsh/composer\\.json$' ],
matchStrings: [
// Alas the only option is regexing to match against the JSON. Four patterns for the four different places the version number appears.
// .require:
'"wordpress/classic-editor-plugin": "(?<currentValue>[0-9.]+)",',
// .repositories[].package.version
'"name": "wordpress/classic-editor-plugin",\\s+"version": "(?<currentValue>[0-9.]+)",',
// .repositories[].package.dist.url
'"url": "https://downloads\\.wordpress\\.org/plugin/classic-editor\\.(?<currentValue>[0-9.]+)\\.zip",',
// .repositories[].package.source.reference
'"url": "https://plugins\\.svn\\.wordpress\\.org/classic-editor/",\\s+"type": "svn",\\s+"reference": "tags/(?<currentValue>[0-9.]+)/"',
],
depNameTemplate: 'wordpress/classic-editor-plugin',
packageNameTemplate: 'classic-editor',
datasourceTemplate: 'custom.wordpress-plugin',
},
],
customDatasources: {
'wordpress-plugin': {
defaultRegistryUrlTemplate: 'https://api.wordpress.org/plugins/info/1.0/{{packageName}}.json',
transformTemplates: [
'{ "releases": $each( versions, function($v, $k) { $match( $k, /^[0-9.]+$/ ) ? { "version": $k } } ) }',
],
},
},

lockFileMaintenance: {
enabled: true,
Expand Down
2 changes: 1 addition & 1 deletion .github/versions.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Versions of tools to use in CI.
PHP_VERSION=8.2
COMPOSER_VERSION=2.7.1
COMPOSER_VERSION=2.7.7
NODE_VERSION=20.8.1
PNPM_VERSION=9.3.0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/post-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
)"
echo "$JSON"
echo "::endgroup::"
ZIPURL="$(jq -r '.artifacts[] | select( .name == "jetpack-build" ) | .archive_download_url' <<<"$JSON")"
ZIPURL="$(jq -r '.artifacts | map( select( .name == "jetpack-build" ) ) | sort_by( .created_at ) | last | .archive_download_url // empty' <<<"$JSON")"
PLUGINS="$(jq -r '.artifacts[] | select( .name == "plugins.tsv" )' <<<"$JSON")"
if [[ -n "$ZIPURL" ]]; then
break
Expand Down
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
vendor/
jetpack_vendor/
/.nova/
/.vscode/
/logs
/allure-results/

## FILES
.DS_Store
*.code-workspace
*.swp
# Custom environment for Docker compose (used by docker-compose.yml)
/.env
Expand Down Expand Up @@ -56,4 +54,6 @@ phpcs.xml
# This file indicates we're in draft mode, which reduces checks
.jetpack-draft

.vscode/settings.json
# VS Code setting files
*.code-workspace
/.vscode/settings.json
9 changes: 9 additions & 0 deletions .pnpmfile.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,15 @@ function fixPeerDeps( pkg ) {
}
}

// It assumes hoisting to find its plugins. Sigh. Add peer deps for the plugins we use.
// https://github.com/ai/size-limit/issues/366
if ( pkg.name === 'size-limit' ) {
pkg.peerDependencies ??= {};
pkg.peerDependencies[ '@size-limit/preset-app' ] = '*';
pkg.peerDependenciesMeta ??= {};
pkg.peerDependenciesMeta[ '@size-limit/preset-app' ] = { optional: true };
}

return pkg;
}

Expand Down
31 changes: 16 additions & 15 deletions .vscode/settings.json → .vscode/settings.dist.jsonc
Original file line number Diff line number Diff line change
@@ -1,41 +1,42 @@
// This is a managed VS Code settings file.
// It is copied into place by `tools/install-vscode-settings.sh`.
// If you no longer want the settings managed, remove these comments.
{
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
// Define schema to allow auto-completion.
"$schema": "vscode://schemas/settings/workspace",
// Don't show these files in VS Code.
"files.exclude": {
"**/.DS_Store/**": true
},
// Don't search these files in VS Code.
"search.exclude": {
"**/.cache/**": true,
"**/.DS_Store/**": true,
"**/.git/**": true,
"**/.hg/**": true,
"**/.svn/**": true,
"**/bower_components/**": true,
"**/CVS/**": true,
"**/jetpack_vendor/**": true,
"**/node_modules/**": true,
"**/vendor/**": true,
"**/vendor/**": true
},
// Don't run Intelephense on these files.
"intelephense.files.exclude": [
"**/.cache/**",
"**/.git/**",
"**/.svn/**",
"**/.hg/**",
"**/.history/**",
"**/bower_components/**",
"**/jetpack_vendor/**",
"**/packages/**/wordpress/**",
"**/projects/**/wordpress/**",
"**/plugins/**/wordpress/**",
"**/vendor/**",
"**/vendor/**"
],
"phpCodeSniffer.autoExecutable": true,
"phpCodeSniffer.standard": "Automatic",
// Have PHPCS ignore these files.
"phpCodeSniffer.exclude": [
"**/.git/**",
"**/.svn/**",
"**/.hg/**",
"**/.cache/**",
"**/jetpack_vendor/**",
"**/vendor/**",
"**/vendor/**"
],
// Use this wp-prettier from this path.
"prettier.prettierPath": "tools/js-tools/node_modules/prettier/index.cjs"
}
20 changes: 20 additions & 0 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
// See https://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "2.0.0",
"tasks": [
{
"label": "Install VS Code settings",
"type": "shell",
"command": "./tools/install-vscode-settings.sh",
"runOptions": {
"runOn": "folderOpen"
},
"problemMatcher": [],
"presentation": {
"reveal": "silent",
"close": true
}
}
]
}
22 changes: 22 additions & 0 deletions docs/git-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,28 @@ $ git rebase jetpack/trunk
$ git push -f origin update/my-changes
```

### Updating an external contributor's PR

If you're working directly with Jetpack trunk and need to update an external contributor's PR, the below commands will be helpful.
This method assumes you are using the `gh` shorthand from the [Github CLI](https://cli.github.com/):

```sh
# Use the Github CLI to checkout the PR with the PR number - for example gh pr checkout 12345.
gh pr checkout xxxxx

# Run merge-base to check where that branch differed from trunk - example git merge-base update/broken-jetpack-feature trunk.
git merge-base forkedbranchname trunk

## With the SHA returned from the above command, we can rebase from that.
git rebase -i the-sha

## Rebase the current branch onto origin/trunk.
git rebase origin/trunk

## Push the updated branch to the forked branch. Note that using --force-with-lease won't work due to an existing GitHub CLI issue, but --force will)
git push --force
```

### Tips for common issues when merging

#### Dealing with lock files
Expand Down
Loading
Loading