-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics: initialize tracking only if the feature is enabled #37984
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as expected! 🚢
Proposed changes:
Other information:
Jetpack product discussion
pfwV0U-4g-p2
https://github.com/Automattic/vulcan/issues/308
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
The PR does not bring any functional changes and can't be tested by itself, so we're testing the existing behavior.
jetpack_wga
option if it already exists (wp option delete jetpack_wga
).wp option get jetpack_wga
, confirm it has both the measurement ID andis_active: true
.wp option get jetpack_wga
, confirmis_active
changed tofalse
.