Boost: Fix removing WP_CACHE when advanced cache wasn't deleted #38033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost should only clean up after itself it it's the last thing that
enabled caching. If it cleans up, it might accidentally break caching
for other plugins.
Fixes #38032
Proposed changes:
WP_CACHE
constant inwp-config.php
(didn't break anything, it just seems odd having a boost related comment when boost might not even be present on a site).Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions:
Test that deactivating Boost doesn't remove WP_CACHE from wp-config.php when it wasn't the last time that had cache enabled
wp-config.php
to make sure the WP_CACHE declaration got moved to the top of the file and there's a comment behind it (// Boost Cache Plugin
);wp-config.php
);wp-config.php
to make sure thatWP_CACHE
did not get removed (the comment from step 3 should be removed).